lkml.org 
[lkml]   [2016]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Patch v3 07/11] driver/edac/fsl_ddr: Add DDR4 type
Date
On 08/08/2016 01:31 AM, Borislav Petkov wrote:
> On Thu, Aug 04, 2016 at 03:58:32PM -0700, York Sun wrote:
>
> <--- Missing commit message.
>
>> Signed-off-by: York Sun <york.sun@nxp.com>
>>
>> ---
>> Change log
>> v3: no change
>> v2: no change
>>
>> drivers/edac/fsl_ddr_edac.c | 12 ++++++++++--
>> drivers/edac/fsl_ddr_edac.h | 1 +
>> 2 files changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c
>> index 60761c0..88ecf7d 100644
>> --- a/drivers/edac/fsl_ddr_edac.c
>> +++ b/drivers/edac/fsl_ddr_edac.c
>> @@ -376,6 +376,9 @@ static void fsl_ddr_init_csrows(struct mem_ctl_info *mci)
>> case DSC_SDTYPE_DDR3:
>
> Btw, those DSC_SDTYPE_* defines are used only here to map to the MEM_*
> ones. You can just as well use the naked numbers here and drop the
> DSC_SDTYPE* ones as it is clear what the naked numbers mean based on how
> they're being used.

OK. Will drop all DSC_SDTYPE_*.

>
>> mtype = MEM_RDDR3;
>> break;
>> + case DSC_SDTYPE_DDR4:
>> + mtype = MEM_RDDR4;
>> + break;
>> default:
>> mtype = MEM_UNKNOWN;
>> break;
>> @@ -391,6 +394,9 @@ static void fsl_ddr_init_csrows(struct mem_ctl_info *mci)
>> case DSC_SDTYPE_DDR3:
>> mtype = MEM_DDR3;
>> break;
>> + case DSC_SDTYPE_DDR4:
>> + mtype = MEM_DDR4;
>> + break;
>> default:
>> mtype = MEM_UNKNOWN;
>> break;
>> @@ -495,8 +501,10 @@ int fsl_ddr_mc_err_probe(struct platform_device *op)
>> }
>>
>> edac_dbg(3, "init mci\n");
>> - mci->mtype_cap = MEM_FLAG_RDDR | MEM_FLAG_RDDR2 |
>> - MEM_FLAG_DDR | MEM_FLAG_DDR2;
>> + mci->mtype_cap = MEM_FLAG_DDR | MEM_FLAG_RDDR |
>> + MEM_FLAG_DDR2 | MEM_FLAG_RDDR2 |
>> + MEM_FLAG_DDR3 | MEM_FLAG_RDDR3 |
>
> DDR3 is silently added too, you can talk about that in the commit
> message, for example.

Right. That gives me something to say in the commit message.

York

\
 
 \ /
  Last update: 2016-08-09 00:41    [W:0.084 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site