Messages in this thread | | | From | Daniel Stone <> | Date | Sat, 6 Aug 2016 18:04:06 +0100 | Subject | Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs |
| |
Hi Tomeu,
On 22 July 2016 at 15:10, Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote: > +/** > + * DOC: CRC ABI > + * > + * DRM device drivers can provide to userspace CRC information of each frame as > + * it reached a given hardware component (a "source"). > + * > + * Userspace can control generation of CRCs in a given CRTC by writing to the
s/can/must/
Is it worth having 'auto' as a default source perhaps?
> + * file dri/0/crtc-N/crc/control in debugfs, with N being the index of the CRTC. > + * Accepted values are source names (which are driver-specific) and the "none" > + * and "auto" keywords. "none" will disable CRC generation and "auto" will let > + * the driver select a default source of frame CRCs for this CRTC.
Is it also worth having 'connector-%s' (named as per sysfs, e.g. connector-HDMI-A-0) as a standardised entry, for cloneable CRTCs which have CRC control on the connector rather than the CRTC?
Cheers, Daniel
| |