lkml.org 
[lkml]   [2016]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 08/11 v2] net/fsl: use of_property_read_bool
    Use of_property_read_bool to check for the existence of a property.

    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @@
    expression e1,e2,x;
    @@
    - if (of_get_property(e1,e2,NULL))
    - x = true;
    - else
    - x = false;
    + x = of_property_read_bool(e1,e2);
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    v2: special case for propagating true and false

    drivers/net/ethernet/freescale/xgmac_mdio.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
    index 7b8fe86..e03b30c 100644
    --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
    +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
    @@ -271,11 +271,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
    goto err_ioremap;
    }

    - if (of_get_property(pdev->dev.of_node,
    - "little-endian", NULL))
    - priv->is_little_endian = true;
    - else
    - priv->is_little_endian = false;
    + priv->is_little_endian = of_property_read_bool(pdev->dev.of_node,
    + "little-endian");

    ret = of_mdiobus_register(bus, np);
    if (ret) {
    \
     
     \ /
      Last update: 2016-08-05 14:01    [W:2.442 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site