Messages in this thread | | | Subject | Re: [PATCH v3] virtio_blk: Fix a slient kernel panic | From | Minfei Huang <> | Date | Thu, 4 Aug 2016 13:35:09 +0800 |
| |
Hi, Michael.
Since Stefan and Cornelia have review-acked this patch, could you mind helping review this patch?
Thanks Minfei
> On Jul 29, 2016, at 16:26, Stefan Hajnoczi <stefanha@gmail.com> wrote: > > On Tue, Jul 19, 2016 at 5:32 AM, Minfei Huang <mnfhuang@gmail.com> wrote: >> From: Minfei Huang <mnghuan@gmail.com> >> >> We do a lot of memory allocation in function init_vq, and don't handle >> the allocation failure properly. Then this function will return 0, >> although initialization fails due to lacking memory. At that moment, >> kernel will panic in guest machine, if virtio is used to drive disk. >> >> To fix this bug, we should take care of allocation failure, and return >> correct value to let caller know what happen. >> >> Tested-by: Chao Fan <fanc.fnst@cn.fujitsu.com> >> Signed-off-by: Minfei Huang <minfei.hmf@alibaba-inc.com> >> Signed-off-by: Minfei Huang <mnghuan@gmail.com> >> --- >> v2: >> - Remove useless initialisation to NULL >> v1: >> - Refactor the patch to make code more readable >> --- >> drivers/block/virtio_blk.c | 26 ++++++++------------------ >> 1 file changed, 8 insertions(+), 18 deletions(-) > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[unhandled content-type:application/pkcs7-signature] | |