Messages in this thread | | | Date | Wed, 3 Aug 2016 22:29:53 -0700 | From | Bjorn Andersson <> | Subject | Re: [RFC][PATCH 3/4] power: reset: Add sram-reboot-mode driver |
| |
On Wed 03 Aug 20:08 PDT 2016, John Stultz wrote:
> On Wed, Aug 3, 2016 at 6:03 PM, Bjorn Andersson > <bjorn.andersson@linaro.org> wrote: > > On Wed 03 Aug 16:05 PDT 2016, John Stultz wrote: > > > > [..] > >> diff --git a/drivers/power/reset/sram-reboot-mode.c b/drivers/power/reset/sram-reboot-mode.c [..] > >> + ret = reboot_mode_register(&sram_rbm->reboot); > > > > I think you should take the time to throw in a > > devm_reboot_mode_register(), it would save you from the > > dev_set_drvdata() and you can drop the remove function. > > So I've only got a vague sense of what your suggesting here. Do you > have a pointer to a good example? >
https://patchwork.kernel.org/patch/9262691/ https://patchwork.kernel.org/patch/9262693/
Regards, Bjorn
| |