lkml.org 
[lkml]   [2016]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] irda: Fix likely typo in output format string
From
Date

On Aug 31, 2016, at 5:31 PM, David Miller wrote:

> From: Oleg Drokin <green@linuxhacker.ru>
> Date: Fri, 26 Aug 2016 23:14:06 -0400
>
>> %ul would print an unsigned with a letter l at the end which does
>> not seem to be desired here, on the other hand the value being printed
>> is u32 so just drop the l instead of converting to %lu
>>
>> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
>
> %u is for unsigned values, and these are "s32" thus signed.

Hm, you are right.
I could swear I saw them as unsigned when I looked at it.

Anyway can they really be negative? they are seconds and usec,
should I change them to u32 too?

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.098 / U:1.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site