lkml.org 
[lkml]   [2016]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH] ASoC: tlv320dac33: Remove deprecated create_singlethread_workqueue
Hello, Peter.

On Wed, Aug 31, 2016 at 10:10:47PM +0300, Peter Ujfalusi wrote:
> > What kind of time frame are we talking about? If it really needs high
> > priority, the right thing to do would be using a WQ_HIGHPRI workqueue.
>
> In order to be tune the performance and power saving during audio playback
> lower is better, but consistency matters more to be able have stable system.
> I have some latency compensation in the code so it could tolerate some drift,
> but big spikes can cause the codec to go underflow and we can not recover from
> that w/o hard reset of the codec.

Gees, that's a brutal failure mode.

> I do believe that Linux got much better over the years since I wrote the dac33
> driver, so I'm fine with the move to system_wq. The most problematic mode (I
> think it was MODE7LP or smthing) is not upstream so this change should not
> break audio on the n9/n950.

Thanks for the explanation!

--
tejun

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.043 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site