Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings | Date | Wed, 31 Aug 2016 19:40:21 +0200 |
| |
Hi,
On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote: > > On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote: > >> Hello Krzysztof, > >> > >> This series removes the usage of the skeleton.dtsi in all the Exynos dts, > >> which allows to get rid of the DTC warnings about a mismatch between the > >> memory nodes' unit names and reg properties. > >> > >> Patches are pretty trivial and shouldn't cause functional changes AFAIK, > >> but only the Exynos5 changes have been tested. The others patches were > >> just built tested. > > > > I think this is a common problem, not only Exynos-specific, so I would > > That's correct. > > > prefer to stick to common pattern. Either all DTS/DTSI include skeleton > > or none of them. > > > > The idea is to get rid of skeleton.dtsi [0], but that will of course take > time until the dtsi is removed from all the files. So this patch is a step > in the right direction so at least Exynos is not a blocker to remove it.
Krzysztof's point is valid. If you are going to convert all DTS/DTSI then it is okay to apply Exynos specific changes, otherwise the code should stay as it is currently.
Exynos won't be a blocker since we have your patches now and they can be applied when/if needed ;)..
> > Best regards, > > Krzysztof > > > > [0]: https://lkml.org/lkml/2016/8/3/195 > > Best regards,
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
| |