lkml.org 
[lkml]   [2016]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints
Hi Steven/Daniel,

On 30 August 2016 at 19:38, Steven Rostedt <rostedt@goodmis.org> wrote:
>> +
>> + TP_printk("ltype=%d, latency=%lu",
>> + __entry->ltype, (unsigned long) __entry->latency)
>
> The print of ltype should be text and not a number. Well, you could
> have both text and a number, but a number is useless for those looking
> at traces.

I am using '__print_symbolic' to display ltype as a string but it
still shows up in
the histogram as a number. Would you suggest to change this as well?

Thanks,
Binoy

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.513 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site