Messages in this thread | | | Subject | Re: [PATCH 3/4] cpuidle/menu: stop seeking deeper idle if current state is too deep | From | Alex Shi <> | Date | Wed, 31 Aug 2016 18:45:58 +0800 |
| |
Hi,
Is there any concern on this patch?
Regards Alex
On 08/25/2016 04:42 PM, Alex Shi wrote: > The obsolete commit 71abbbf85 want to introduce a dynamic cstates, > but it was removed for long time. Just left the nonsense deeper cstate > checking. > > Since all target_residency and exit_latency are going longer in deeper > idle state, no needs to waste some cpu cycle on useless seeking. > > Signed-off-by: Alex Shi <alex.shi@linaro.org> > To: linux-kernel@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: Alex Shi <alex.shi@linaro.org> > Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk> > Cc: Arjan van de Ven <arjan@linux.intel.com> > Cc: Rik van Riel <riel@redhat.com> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> > --- > drivers/cpuidle/governors/menu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c > index 03d38c2..bb58e2a 100644 > --- a/drivers/cpuidle/governors/menu.c > +++ b/drivers/cpuidle/governors/menu.c > @@ -358,9 +358,9 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) > if (s->disabled || su->disable) > continue; > if (s->target_residency > data->predicted_us) > - continue; > + break; > if (s->exit_latency > latency_req) > - continue; > + break; > > data->last_state_idx = i; > } >
| |