lkml.org 
[lkml]   [2016]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v10 1/4] i2c: tegra: use readl_poll_timeout after config_load reg programmed
On Wed, Aug 31, 2016 at 12:41:16AM +0530, Shardar Shariff Md wrote:
> After CONFIG_LOAD register is programmed instead of explicitly waiting
> for timeout, use readl_poll_timeout() to check for register value to get
> updated or wait till timeout.
>
> Signed-off-by: Shardar Shariff Md <smohammed@nvidia.com>
> ---
> Changes in v4:
> - Split timeout calculation to separate patch
>
> Changes in v5:
> - Move disabling of clock to separate patch
>
> Changes in v8:
> - 1st change of [PATCH v7] series is merged, v8 is rebased on top of
> merged change, here patch series is changed accordingly.
> - Updated the commit message as per review to properly reflect change.
> - calculate the register offset seperately to make code more readable.
>
> Changes in v9:
> - Use readl_poll_timeout() instead of readx_poll_timeout()
>
> Changes in V10:
> - Rebase on top of [PATCH V2 0/9] Some Tegra I2C Updates

Thanks for the rebase! However, my code checkers showed a few warnings:

SPARSE
drivers/i2c/busses/i2c-tegra.c:504:21: warning: symbol 'val' shadows an earlier one
drivers/i2c/busses/i2c-tegra.c:451:13: originally declared here

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.045 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site