lkml.org 
[lkml]   [2016]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints
On Tue, 30 Aug 2016 15:11:26 +0530
Binoy Jayan <binoy.jayan@linaro.org> wrote:

> On 29 August 2016 at 15:13, Daniel Wagner <daniel.wagner@bmw-carit.de> wrote:
> > Hi Binoy,
> >
> > Some minor nitpicking.
> >
> > As Steven already pointed out, the cpu field is available in all traces.
> > It's one of the predefined fields (see
> > kernel/trace/trace_events.c/trace_define_generic_fields()). Just drop it.
> >
>
> Hi Daniel,
>
> Thank you for looking at the patch again. When I do not use cpu as a field,
> I am not able to make it part of the key or value fields. I can only
> use cpu in the
> filter predicate.
>
> For example, the following trigger does not seem to work:
> 'hist:key=ltype,cpu:val=latency:sort=ltype,cpu if ltype==0'
>
> But the following works:
> 'hist:key=ltype,latency:val=hitcount:sort=latency if cpu==1'

What about using "CPU" (all caps)? Look at
kernel/trace/trace_events_filter.c for FILTER_CPU.

Lets not add fields when we can fix the generic code to process these.

Thanks!

-- Steve

\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.515 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site