Messages in this thread | | | Date | Wed, 3 Aug 2016 09:13:52 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH 05/19] x86/dumpstack: fix function graph tracing stack dump reliability issues |
| |
On Tue, Aug 02, 2016 at 11:45:30PM -0400, Steven Rostedt wrote: > On Tue, 2 Aug 2016 22:31:25 -0500 > Josh Poimboeuf <jpoimboe@redhat.com> wrote: > > Yeah, we do need to add a parameter to ftrace_push_return_trace(). But > > callers which don't implement it could just pass zero like they do with > > 'fp'. > > > > Right, if zero is passed in, then just ignore it.
I still think we need the define though, because there will be two versions of ftrace_graph_ret_addr().
-- Josh
| |