lkml.org 
[lkml]   [2016]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] arm64: dts: rockchip: Provide power-domains for sd/sdio/emmc controllers
Date
Hi Shawn,

Am Montag, 1. August 2016, 16:41:14 schrieb Shawn Lin:
> The PM domain will be "powered on" once we have registered our PM domain
> with genpd and when the device (dw_mmc etc) gets attached to the domain.
> The attach occurs when the platform bus'->probe() function get invoked
> for the device.
>
> Due to this, we should be able to deploy genpd support by adding the
> phandle of related power-domains without first having to deploying
> runtime PM support in the related drivers.
>
> Let's do this in case of taking risk of accessing controller when the
> genpd is in "power off" status as the genpd will turn off all the
> power domains which are the referenced by drivers.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

you're missing the subnodes below power: power-controller defining the power-
domains, - including the needed clocks. Thus currently you end up defering
probe of the emmc and friends indefinitly.

Ideally do it in this patch together with the assignment.

Thanks
Heiko

\
 
 \ /
  Last update: 2016-08-03 14:41    [W:0.137 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site