Messages in this thread | | | Subject | Re: [PATCH v2] fix:brcmfmac: add missing header dependencies | From | Arend Van Spriel <> | Date | Mon, 29 Aug 2016 09:59:46 +0200 |
| |
On 27-8-2016 8:08, Baoyou Xie wrote: > We get 1 warning when biuld kernel with W=1: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing- > prototypes] > > In fact, this function is declared in brcmfmac/debug.h, so this patch > add missing header dependencies
Thanks for this fix, but please remove the 'fix:' prefix in the subject as it just noise.
Regards, Arend
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c > index a10f35c..fe67559 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c > @@ -19,6 +19,7 @@ > #ifndef __CHECKER__ > #define CREATE_TRACE_POINTS > #include "tracepoint.h" > +#include "debug.h" > > void __brcmf_err(const char *func, const char *fmt, ...) > { >
| |