lkml.org 
[lkml]   [2016]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] sparc: Use kmalloc_array() in three functions


    Am 29.08.2016 11:47, schrieb Paolo Bonzini:
    >
    >
    > On 25/08/2016 10:22, SF Markus Elfring wrote:
    >> --- a/arch/sparc/kernel/led.c
    >> +++ b/arch/sparc/kernel/led.c
    >> @@ -69,7 +69,7 @@ static ssize_t led_proc_write(struct file *file, const char __user *buffer,
    >> if (count > LED_MAX_LENGTH)
    >> count = LED_MAX_LENGTH;
    >>
    >> - buf = kmalloc(sizeof(char) * (count + 1), GFP_KERNEL);
    >> + buf = kmalloc_array(count + 1, sizeof(*buf), GFP_KERNEL);
    >> if (!buf)
    >> return -ENOMEM;
    >>
    >
    > Here it's probably best to just remove sizeof(char) completely, as it's
    > 1 by definition.
    >
    > Paolo


    I would not do so, if you ever change buf to something else it would break,
    having a sizeof(*buf) here is harmless and a known pattern.

    re,
    wh

    \
     
     \ /
      Last update: 2016-09-17 09:58    [W:3.212 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site