lkml.org 
[lkml]   [2016]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] memstick: r592: add missing declaration in r592.h
Date
We get 1 warning when build kernel with W=1:
drivers/memstick/host/r592.c:50:13: warning: no previous prototype for 'memstick_debug_get_tpc_name' [-Wmissing-prototypes]

in fact, function memstick_debug_get_tpc_name is implemented in r592.c
and exported but need to be declared in header file.

so this patch add its declaration in r592.h

in addition, this function don't check if the parameter tpc is valid,
it will cause a panic and incur attack.
but this need another patch to fix it.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/memstick/host/r592.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/memstick/host/r592.h b/drivers/memstick/host/r592.h
index c5726c1..8f69fc1 100644
--- a/drivers/memstick/host/r592.h
+++ b/drivers/memstick/host/r592.h
@@ -172,4 +172,5 @@ struct r592_device {
#define dbg_verbose(format, ...) __dbg(2, format, ## __VA_ARGS__)
#define dbg_reg(format, ...) __dbg(3, format, ## __VA_ARGS__)

+const char *memstick_debug_get_tpc_name(int tpc);
#endif
--
2.7.4
\
 
 \ /
  Last update: 2016-09-17 09:58    [W:0.060 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site