Messages in this thread Patch in this message | | | From | Chao Yu <> | Subject | [PATCH] f2fs crypto: avoid unneeded memory allocation in ->readdir | Date | Sun, 28 Aug 2016 22:00:12 +0800 |
| |
From: Chao Yu <yuchao0@huawei.com>
When decrypting dirents in ->readdir, fscrypt_fname_disk_to_usr won't change content of original encrypted dirent, we don't need to allocate additional buffer for storing mirror of it, so get rid of it.
Signed-off-by: Chao Yu <yuchao0@huawei.com> --- fs/f2fs/dir.c | 7 ------- 1 file changed, 7 deletions(-)
diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index 3522f6f..fbc8ede 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -796,16 +796,9 @@ bool f2fs_fill_dentries(struct dir_context *ctx, struct f2fs_dentry_ptr *d, int save_len = fstr->len; int ret; - de_name.name = f2fs_kmalloc(de_name.len, GFP_NOFS); - if (!de_name.name) - return false; - - memcpy(de_name.name, d->filename[bit_pos], de_name.len); - ret = fscrypt_fname_disk_to_usr(d->inode, (u32)de->hash_code, 0, &de_name, fstr); - kfree(de_name.name); if (ret < 0) return true; -- 2.7.2
| |