lkml.org 
[lkml]   [2016]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Subjectconstification and cocci / kernel build test robot ?
    From
    Date
    On Sat, 2016-08-27 at 20:59 +0200, Julia Lawall wrote:
    >  Make sure (of/i2c/platform)_device_id tables are NULL terminated
    > Generated by: scripts/coccinelle/misc/of_table.cocci

    Along the same lines, I submitted a manually generated
    patch to add const to some of these structs.

    https://lkml.org/lkml/2016/8/26/494

    Could cocci and/or the kbuild test robot check for structs
    that could or should be const?


    > Please take the patch only if it's a positive warning. Thanks!
    []
    > +++ b/drivers/thermal/intel_bxt_pmic_thermal.c
    > @@ -281,6 +281,7 @@ static struct platform_device_id pmic_th
    >                 .name = "bxt_wcove_thermal",
    >                 .driver_data = (kernel_ulong_t)&bxtwc_thermal_data,
    >         },
    > +       {},
    >  };
    >
    >  static struct platform_driver pmic_thermal_driver = {

    \
     
     \ /
      Last update: 2016-09-17 09:58    [W:3.949 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site