Messages in this thread | | | Date | Sat, 27 Aug 2016 21:26:14 +0300 | From | Yuval Shaia <> | Subject | Re: [PATCH] fix:infiniband:hw:cxgb4:qp:mark symbols static where possible |
| |
One minor comment inline. Besides that: Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
On Sun, Aug 28, 2016 at 12:00:18AM +0800, Baoyou Xie wrote: > We get 1 warning when biuld kernel with W=1:
s/biuld/build
> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for '_free_qp' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared > and don't need a declaration, but can be made static. > so this patch marks it 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > --- > drivers/infiniband/hw/cxgb4/qp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c > index edb1172..6904352 100644 > --- a/drivers/infiniband/hw/cxgb4/qp.c > +++ b/drivers/infiniband/hw/cxgb4/qp.c > @@ -683,7 +683,7 @@ static int build_inv_stag(union t4_wr *wqe, struct ib_send_wr *wr, > return 0; > } > > -void _free_qp(struct kref *kref) > +static void _free_qp(struct kref *kref) > { > struct c4iw_qp *qhp; > > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |