lkml.org 
[lkml]   [2016]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pwm-regulator: Add support for a fixed delay after duty cycle changes
Hi Matthias,

[auto build test WARNING on robh/for-next]
[also build test WARNING on v4.8-rc3 next-20160825]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/pwm-regulator-Add-support-for-a-fixed-delay-after-duty-cycle-changes/20160827-071710
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: i386-randconfig-x017-201634 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All warnings (new ones prefixed by >>):

drivers/regulator/pwm-regulator.c: In function 'pwm_regulator_set_voltage':
>> drivers/regulator/pwm-regulator.c:245:54: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
if (!pwm_regulator_is_enabled(rdev) || (delay == 0) && (ramp_delay == 0))
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~

vim +245 drivers/regulator/pwm-regulator.c

229 else
230 dutycycle = min_uV_duty + dutycycle;
231
232 pwm_set_relative_duty_cycle(&pstate, dutycycle, duty_unit);
233
234 ret = pwm_apply_state(drvdata->pwm, &pstate);
235 if (ret) {
236 dev_err(&rdev->dev, "Failed to configure PWM: %d\n", ret);
237 return ret;
238 }
239
240 if (req_min_uV > old_uV)
241 delay = drvdata->settle_time_up_us;
242 else
243 delay = drvdata->settle_time_down_us;
244
> 245 if (!pwm_regulator_is_enabled(rdev) || (delay == 0) && (ramp_delay == 0))
246 return 0;
247
248 if (ramp_delay != 0)
249 /* Adjust ramp delay to uS and add to settle time. */
250 delay += DIV_ROUND_UP(abs(req_min_uV - old_uV), ramp_delay);
251
252 usleep_range(delay, delay + DIV_ROUND_UP(delay, 10));
253

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/octet-stream]
\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.107 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site