lkml.org 
[lkml]   [2016]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization
Em Thu, Aug 25, 2016 at 03:59:43PM +0200, Jiri Olsa escreveu:
> On Thu, Aug 25, 2016 at 09:50:04PM +0900, Masami Hiramatsu wrote:
>
> SNIP
>
> > > After applying patch:
> > >
> > > $ ./perf probe -x ./test 'foo i'
> > > $ cat /sys/kernel/debug/tracing/uprobe_events
> > > p:probe_test/foo /home/ravi/test:0x0000000000000541 i=-4(%bp):s32
> > >
> > > $ ./perf record -e probe_test:foo ./test
> > > $ ./perf script
> > > test 6300 [001] 5877.879327: probe_test:foo: (400541) i=42
> > >
> > > No need to skip prologue for optimized case since debug info is correct
> > > for each instructions for -O2 -g. For more details please visit:
> > > https://bugzilla.redhat.com/show_bug.cgi?id=612253#c6
> > >
> > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> >
> > Looks good for me:)
> >
> > Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> >
> > Jiri, Michael, please try this. Ravi's patch can fix your problem.
>
> yes, that fixes the problem for me

Ok, so I'll add a Tested-by: Jiri, ok? And push it via perf/urgent.

- Arnaldo

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.042 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site