Messages in this thread | | | Date | Thu, 25 Aug 2016 15:04:27 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 2/2] perf tool: add container identifier entry related changes |
| |
On Thu, Aug 25, 2016 at 05:28:03PM +0530, Hari Bathini wrote: > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index d9b80ef..d35fbd3 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -929,6 +929,8 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, > if (opts->sample_transaction) > perf_evsel__set_sample_bit(evsel, TRANSACTION); > > + perf_evsel__set_sample_bit(evsel, CID); > + > if (opts->running_time) { > evsel->attr.read_format |= > PERF_FORMAT_TOTAL_TIME_ENABLED |
Does this mean its enabled by default? Why? By growing the default sample to include everything under the sun we make profiling slower for everyone.
| |