lkml.org 
[lkml]   [2016]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 0/7] scpi: Add support for legacy SCPI protocol
From
Date
On 08/23/2016 01:46 PM, Neil Armstrong wrote:
> This patchset aims to support the legacy SCPI firmware implementation that was
> delivered as early technology preview for the JUNO platform.
>
> Finally a stable, maintained and public implementation for the SCPI protocol
> has been upstreamed part of the JUNO support and it is the recommended way
> of implementing SCP communication on ARMv8 platforms.
>
> The Amlogic GXBB platform is using this legacy protocol, as the RK3368 & RK3399
> platforms. This patchset will only add support for Amlogic GXBB SoC.
>
> This patchset add support for the legacy protocol in the arm_scpi.c file,
> avoiding code duplication.
>
> Last RFC discution tread can be found at : https://lkml.org/lkml/2016/8/9/210
>
> The last patch depends on the "Platform MHU" dtsi patch.
>
> Changes since v1 at : http://lkml.kernel.org/r/1471515066-3626-1-git-send-email-narmstrong@baylibre.com
> - Dropped vendor_send_message and rockchip vendor mechanism patches
> - Merged alternate functions into main functions using is_legacy boolean
> - Added DT match table to set is_legacy to true
> - Kept alternate scpi_ops structure for legacy
>
> Neil Armstrong (7):
> scpi: Add alternative legacy structures, functions and macros
> scpi: Use legacy variants command index calling scpi_send_message
> scpi: Add support for Legacy match table for Amlogic GXBB SoC
> scpi: grow MAX_DVFS_OPPS to 16 entries
> dt-bindings: Add support for Amlogic GXBB SCPI Interface
> ARM64: dts: meson-gxbb: Add SRAM node
> ARM64: dts: meson-gxbb: Add SCPI with cpufreq & sensors Nodes
>
> Documentation/devicetree/bindings/arm/arm,scpi.txt | 8 +-
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 45 ++++
> drivers/firmware/arm_scpi.c | 279 +++++++++++++++++++--
> 3 files changed, 302 insertions(+), 30 deletions(-)
>

Hi Sudeep,

Sorry but I posted this V2 before you had time to look at my previous v1 replies...

In this serie, I merged the scpi_send_message, but I must still evaluate how it's possible
to use the list to queue commands.

Here I used if(is_legacy) to stop duplicating functions, is this ok for you ?

Thanks,
Neil

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.064 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site