lkml.org 
[lkml]   [2016]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] livepatch/module: make TAINT_LIVEPATCH module-specific
On Wed, 24 Aug 2016, Josh Poimboeuf wrote:

> There's no reliable way to determine which module tainted the kernel
> with CONFIG_LIVEPATCH. For example, /sys/module/<klp module>/taint
> doesn't report it. Neither does the "mod -t" command in the crash tool.
>
> Make it crystal clear who the guilty party is by converting
> CONFIG_LIVEPATCH to a module taint flag.
>
> This changes the behavior a bit: now the the flag gets set when the
> module is loaded, rather than when it's enabled.
>
> Reviewed-by: Chunyu Hu <chuhu@redhat.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

I like this change.

Rusty, in case you're okay with it as well, could you please either
provide your Ack so that I could take it through livepatching.git?
Alternatively, if you prefer to merge this through your tree, please feel
free to add

Acked-by: Jiri Kosina <jkosina@suse.cz>

Thanks,

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.288 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site