lkml.org 
[lkml]   [2016]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH RFC V3.5] leds: trigger: Introduce an USB port trigger
    Date
    Rafał Miłecki <zajec5@gmail.com> writes:

    > The last big missing thing is Documentation update (this is why I'm
    > sending RFC). Greg pointed out we should have some entries in
    > Documentation/ABI, but it seems none of triggers have it.

    There's a lot missing, but there is at least one exception:
    The "inverted" attribute of the gpio and backlight triggers is
    documented as part of Documentation/ABI/testing/sysfs-class-led

    > Any idea why is that?

    Manual enforcement fails from time to time? The requirement was less
    strict in the early days of sysfs? Does it matter?

    > Do we need to change it? Or is it required for new code only?

    The lack of ABI docs is a bug. Don't add new code with known bugs. Old
    code should be fixed, but there is no immediate *need* to fix it.


    Bjørn

    \
     
     \ /
      Last update: 2016-09-17 09:57    [W:4.547 / U:0.600 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site