Messages in this thread | | | From | Bjørn Mork <> | Subject | Re: [PATCH RFC V3.5] leds: trigger: Introduce an USB port trigger | Date | Wed, 24 Aug 2016 20:48:02 +0200 |
| |
Rafał Miłecki <zajec5@gmail.com> writes:
> The last big missing thing is Documentation update (this is why I'm > sending RFC). Greg pointed out we should have some entries in > Documentation/ABI, but it seems none of triggers have it.
There's a lot missing, but there is at least one exception: The "inverted" attribute of the gpio and backlight triggers is documented as part of Documentation/ABI/testing/sysfs-class-led
> Any idea why is that?
Manual enforcement fails from time to time? The requirement was less strict in the early days of sysfs? Does it matter?
> Do we need to change it? Or is it required for new code only?
The lack of ABI docs is a bug. Don't add new code with known bugs. Old code should be fixed, but there is no immediate *need* to fix it.
Bjørn
| |