lkml.org 
[lkml]   [2016]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 6/8] hisi_sas: fail tmf task prep when port detached
    From
    Date
    On 08/24/2016 01:05 PM, John Garry wrote:
    > When the port is detached we cannot execute a TMF,
    > as there can be no device attached to the port.
    >
    > Signed-off-by: John Garry <john.garry@huawei.com>
    > ---
    > drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
    > index 280a19d..73f581f 100644
    > --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
    > +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
    > @@ -204,7 +204,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_hba *hisi_hba,
    > return rc;
    > }
    > port = device->port->lldd_port;
    > - if (port && !port->port_attached && !tmf) {
    > + if (port && !port->port_attached) {
    > if (sas_protocol_ata(task->task_proto)) {
    > struct task_status_struct *ts = &task->task_status;
    >
    >
    Reviewed-by: Hannes Reinecke <hare@suse.com>

    Cheers,

    Hannes
    --
    Dr. Hannes Reinecke Teamlead Storage & Networking
    hare@suse.de +49 911 74053 688
    SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
    GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
    HRB 21284 (AG Nürnberg)

    \
     
     \ /
      Last update: 2016-09-17 09:57    [W:3.733 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site