lkml.org 
[lkml]   [2016]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging:xgifb:remove unused code
On Tue, Aug 23, 2016 at 03:26:50PM +0800, dingxiang wrote:
> The variable data is assigned but never used in rest code.
>
> Signed-off-by: Ding Xiang <dingxiang@huawei.com>
> ---

Your name in Signed-off-by: and From: doesnot match.

> drivers/staging/xgifb/vb_setmode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 50c8ea4..71bb9ca 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex,
> tempax |= 0x40;
> xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax);
> - data = xgifb_reg_get(pVBInfo->P3d4, 0x07);
> tempax = 0;
> if (tempbx & 0x04)

The patch will not apply. Its missing two blank lines which the original
code has.

regards
sudip

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.038 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site