lkml.org 
[lkml]   [2016]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] ASoc: simple-card-utils: add __printf attribute
From
Date
Hello,

After I sent the following patch a few weeks ago, I have not received
any feedback. Could you please review it?

Thanks,
Nicolas

On 06/08/16 11:58, Nicolas Iooss wrote:
> asoc_simple_card_set_dailink_name() uses devm_kvasprintf() to format
> some of its arguments. Adding a __printf attribute to this function
> makes it possible to detect at compile-time errors related to format
> strings.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
> include/sound/simple_card_utils.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h
> index 86088aed9002..3207b1a70d38 100644
> --- a/include/sound/simple_card_utils.h
> +++ b/include/sound/simple_card_utils.h
> @@ -27,6 +27,7 @@ int asoc_simple_card_parse_daifmt(struct device *dev,
> struct device_node *codec,
> char *prefix,
> unsigned int *retfmt);
> +__printf(3, 4)
> int asoc_simple_card_set_dailink_name(struct device *dev,
> struct snd_soc_dai_link *dai_link,
> const char *fmt, ...);
>

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.044 / U:1.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site