lkml.org 
[lkml]   [2016]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers
From
Date
On Fri, 2016-08-19 at 09:36 -0500, Rob Herring wrote:
> On Fri, Aug 19, 2016 at 10:14:10PM +0930, Andrew Jeffery wrote:
> >
> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > ---
> >
> > Since v1:
> >
> > Rob: I haven't added your Acked-by here as I've made the following changes and
> > wanted to get your input:
> >
> > * Remove interrupt-controller as an optional property
> > * Defer to interrupt-controller bindings document for sub-node properties
> >
> > I had a discussion with Joel about whether the interrupt-controller capability
> > should be optional and the conclusion was that it should always be configured
> > by the driver. This makes an optional interrupt-controller property feel
> > redundant (and possibly inaccurate if left out) so I've removed it.
> I don't follow. What do you mean byt "configured by the driver". If the 
> block supports interrupts, then it should be marked as an 
> interrupt-controller. It never should have been optional. The OS can 
> ignore the interrupt properties if it chooses. 

Right, clearly there was some confusion on my part. I will fix that up.
Thanks for clarifying.

Andrew
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.129 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site