lkml.org 
[lkml]   [2016]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] drm/amdgpu/gmc7: remove dead code
From
Date
On 08/21/2016 08:29 PM, Joe Perches wrote:
> On Sun, 2016-08-21 at 20:06 +0200, Heinrich Schuchardt wrote:
>> In an if block for (running == 0) running cannot be non-zero.
>
> This code could also be better unindented by one level
> (all of the block would fit 80 columns) by changing:
>
> if (running == 0) {
> [code...]
> }
>
> return 0;
>
> to:
>
> if (running)
> return 0;
>
> [code...]
>
> return 0;

Should I revise my patch?
Or should this be an additional patch?


\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.042 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site