lkml.org 
[lkml]   [2016]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/2] IB/core: Use memdup_user() rather than duplicating its implementation
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 21 Aug 2016 18:45:22 +0200

    Reuse existing functionality from memdup_user() instead of keeping
    duplicate source code.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    include/rdma/ib_verbs.h | 9 ++-------
    1 file changed, 2 insertions(+), 7 deletions(-)

    diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
    index 6f667dd..033610b 100644
    --- a/include/rdma/ib_verbs.h
    +++ b/include/rdma/ib_verbs.h
    @@ -2205,16 +2205,11 @@ static inline bool ib_is_udata_cleared(struct ib_udata *udata,
    if (len > USHRT_MAX)
    return false;

    - buf = kmalloc(len, GFP_KERNEL);
    - if (!buf)
    + buf = memdup_user(p, len);
    + if (IS_ERR(buf))
    return false;

    - if (copy_from_user(buf, p, len))
    - goto free;
    -
    ret = !memchr_inv(buf, 0, len);
    -
    -free:
    kfree(buf);
    return ret;
    }
    --
    2.9.3
    \
     
     \ /
      Last update: 2016-09-17 09:57    [W:4.043 / U:1.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site