Messages in this thread Patch in this message | | | From | Willy Tarreau <> | Subject | [PATCH 3.10 133/180] ALSA: timer: Fix leak in events via snd_timer_user_ccallback | Date | Sun, 21 Aug 2016 17:31:03 +0200 |
| |
From: Kangjie Lu <kangjielu@gmail.com>
commit 9a47e9cff994f37f7f0dbd9ae23740d0f64f9fe6 upstream.
The stack object âr1â has a total size of 32 bytes. Its field âeventâ and âvalâ both contain 4 bytes padding. These 8 bytes padding bytes are sent to user without being initialized.
Signed-off-by: Kangjie Lu <kjlu@gatech.edu> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Willy Tarreau <w@1wt.eu> --- sound/core/timer.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/core/timer.c b/sound/core/timer.c index 54ff806..7ba0709 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -1208,6 +1208,7 @@ static void snd_timer_user_ccallback(struct snd_timer_instance *timeri, tu->tstamp = *tstamp; if ((tu->filter & (1 << event)) == 0 || !tu->tread) return; + memset(&r1, 0, sizeof(r1)); r1.event = event; r1.tstamp = *tstamp; r1.val = resolution; -- 2.8.0.rc2.1.gbe9624a
| |