lkml.org 
[lkml]   [2016]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1058/1285] Replace numeric parameter like 0444 with macro
Date
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
fs/pstore/platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index 588461b..1d230d6 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -45,7 +45,7 @@
* to let someone see the entry
*/
static int pstore_update_ms = -1;
-module_param_named(update_ms, pstore_update_ms, int, 0600);
+module_param_named(update_ms, pstore_update_ms, int, S_IRUSR | S_IWUSR);
MODULE_PARM_DESC(update_ms, "milliseconds before pstore updates its content "
"(default is -1, which means runtime updates are disabled; "
"enabling this option is not safe, it may lead to further "
@@ -590,5 +590,5 @@ static void pstore_timefunc(unsigned long dummy)
mod_timer(&pstore_timer, jiffies + msecs_to_jiffies(pstore_update_ms));
}

-module_param(backend, charp, 0444);
+module_param(backend, charp, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(backend, "Pstore backend to use");
--
2.9.2
\
 
 \ /
  Last update: 2016-08-02 17:01    [W:0.064 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site