lkml.org 
[lkml]   [2016]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1038/1285] Replace numeric parameter like 0444 with macro
On Tue, Aug 02, 2016 at 08:10:47PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

I actually find using the macros significantly **decrease* the
readiability of the code. A quick glance at 0644 quickly tells you
what the permissions are. Parsing S_IRUSR | S_IRGRP | S_IROTH takes
longer, and is more error prone.

NACK.

- Ted

\
 
 \ /
  Last update: 2016-08-03 00:01    [W:0.832 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site