Messages in this thread | | | Date | Tue, 2 Aug 2016 22:30:35 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] uprobe: Add uprobe_pre/post_sstep_notifier to NOKPROBE_SYMBOL |
| |
On 08/02, Pratyush Anand wrote: > > uprobe_pre_sstep_notifier and uprobe_post_sstep_notifier are called from > debug exception handler, so blacklist them for kprobing.
Let me add kprobes maintainers, I am a bit confused...
> @@ -1997,6 +1998,7 @@ int uprobe_pre_sstep_notifier(struct pt_regs *regs) > set_thread_flag(TIF_UPROBE); > return 1; > } > +NOKPROBE_SYMBOL(uprobe_pre_sstep_notifier); > > /* > * uprobe_post_sstep_notifier gets called in interrupt context as part of notifier > @@ -2014,6 +2016,7 @@ int uprobe_post_sstep_notifier(struct pt_regs *regs) > set_thread_flag(TIF_UPROBE); > return 1; > } > +NOKPROBE_SYMBOL(uprobe_post_sstep_notifier);
but if we need to blacklist uprobe_pre/post_sstep_notifier then we also need to blacklist their caller, arch_uprobe_exception_notify() ?
and every .notifier_call used in register_die_notifier() ?
Oleg.
| |