lkml.org 
[lkml]   [2016]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] usb: dwc2: Remove deprecated create_singlethread_workqueue
From
Date
++ Felipe

On 7/28/2016 1:27 AM, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue replaces the deprecated
> create_singlethread_workqueue.
>
> There are multiple work items on the work queue, which require
> ordering. Hence, an ordered workqueue has been used.
>
> The workqueue "wq_otg" is not being used on a memory reclaim path.
> Hence, WQ_MEM_RECLAIM has not been set.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> drivers/usb/dwc2/hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 2df3d04..df5a065 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -5040,7 +5040,7 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg, int irq)
>
> /* Create new workqueue and init work */
> retval = -ENOMEM;
> - hsotg->wq_otg = create_singlethread_workqueue("dwc2");
> + hsotg->wq_otg = alloc_ordered_workqueue("dwc2", 0);
> if (!hsotg->wq_otg) {
> dev_err(hsotg->dev, "Failed to create workqueue\n");
> goto error2;
> --
> 2.1.4
>
>


Acked-by: John Youn <johnyoun@synopsys.com>

John

\
 
 \ /
  Last update: 2016-08-02 22:21    [W:0.044 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site