Messages in this thread | | | From | Yinghai Lu <> | Date | Tue, 2 Aug 2016 11:01:50 -0700 | Subject | Re: [PATCH v1 1/2] x86/power/64: Support unaligned addresses for temporary mapping |
| |
On Mon, Aug 1, 2016 at 5:36 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > On Monday, August 01, 2016 10:07:59 AM Thomas Garnier wrote: >> Correctly setup the temporary mapping for hibernation. Previous >> implementation assumed the address was aligned on the PGD level. With >> KASLR memory randomization enabled, the address is randomized on the PUD >> level. This change supports unaligned address up to PMD. > > This code is shared with kexec AFAICS, so it likely is better to push it > through tip rather than through the PM tree.
Only calling path via arch/x86/power/hibernate_64.c have kernel_mapping = true; other two paths: arch/x86/boot/compressed/pagetable.c and arch/x86/kernel/machine_kexec_64.c all have kernel_mapping as false.
maybe that path need simplified kernel_physical_mapping_init() instead?
Thanks
Yinghai
| |