lkml.org 
[lkml]   [2016]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 0600/1285] Replace numeric parameter like 0444 with macro
    Date
    I find that the developers often just specified the numeric value
    when calling a macro which is defined with a parameter for access permission.
    As we know, these numeric value for access permission have had the corresponding macro,
    and that using macro can improve the robustness and readability of the code,
    thus, I suggest replacing the numeric parameter with the macro.

    Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
    Signed-off-by: Baole Ni <baolex.ni@intel.com>
    ---
    drivers/media/usb/dvb-usb/dib0700_core.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media/usb/dvb-usb/dib0700_core.c
    index bf890c3..37b6228 100644
    --- a/drivers/media/usb/dvb-usb/dib0700_core.c
    +++ b/drivers/media/usb/dvb-usb/dib0700_core.c
    @@ -10,11 +10,11 @@

    /* debug */
    int dvb_usb_dib0700_debug;
    -module_param_named(debug,dvb_usb_dib0700_debug, int, 0644);
    +module_param_named(debug,dvb_usb_dib0700_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
    MODULE_PARM_DESC(debug, "set debugging level (1=info,2=fw,4=fwdata,8=data (or-able))." DVB_USB_DEBUG_STATUS);

    static int nb_packet_buffer_size = 21;
    -module_param(nb_packet_buffer_size, int, 0644);
    +module_param(nb_packet_buffer_size, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
    MODULE_PARM_DESC(nb_packet_buffer_size,
    "Set the dib0700 driver data buffer size. This parameter "
    "corresponds to the number of TS packets. The actual size of "
    --
    2.9.2
    \
     
     \ /
      Last update: 2016-08-02 19:01    [W:4.673 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site