Messages in this thread | | | Date | Tue, 2 Aug 2016 11:30:48 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 1/4] tools lib traceevent: Add install_headers target |
| |
On Tue, Aug 02, 2016 at 11:19:08AM +0900, Namhyung Kim wrote: > Hi Jiri, > > On Mon, Aug 01, 2016 at 07:41:29PM +0200, Jiri Olsa wrote: > > Adding install_headers target to install all headers > > under 'include/traceevent' path, like: > > > > $ make DESTDIR=/tmp/krava prefix=/usr install_headers > > $ find /tmp/krava/ -type f > > /tmp/krava/usr/include/traceevent/kbuffer.h > > /tmp/krava/usr/include/traceevent/event-utils.h > > /tmp/krava/usr/include/traceevent/event-parse.h > > > > Cc: Steven Rostedt <rostedt@goodmis.org> > > Link: http://lkml.kernel.org/n/tip-if70lj3zhdc3csdqm5webjvc@git.kernel.org > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > > --- > > tools/lib/traceevent/Makefile | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile > > index 7851df1490e0..8e44bea646ee 100644 > > --- a/tools/lib/traceevent/Makefile > > +++ b/tools/lib/traceevent/Makefile > > @@ -240,7 +240,7 @@ define do_install > > if [ ! -d '$(DESTDIR_SQ)$2' ]; then \ > > $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$2'; \ > > fi; \ > > - $(INSTALL) $1 '$(DESTDIR_SQ)$2' > > + $(INSTALL) $(if $3,-m $3,) $1 '$(DESTDIR_SQ)$2' > > endef > > > > define do_install_plugins > > @@ -264,6 +264,12 @@ install_plugins: $(PLUGINS) > > $(call QUIET_INSTALL, trace_plugins) \ > > $(call do_install_plugins, $(PLUGINS)) > > > > +install_headers: > > + $(call QUIET_INSTALL, headers) \ > > + $(call do_install,event-parse.h,$(prefix)/include/traceevent,644); \ > > + $(call do_install,event-utils.h,$(prefix)/include/traceevent,644); \ > > + $(call do_install,kbuffer.h,$(prefix)/include/traceevent,644) > > For possible future changes, what about making it to use the wildcard > somehow? Or else, we could define HEADER_FILES variable..
right we can.. but I dont expect increase of header files any time soon ;-)
jirka
| |