Messages in this thread | | | Date | Tue, 2 Aug 2016 16:46:30 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH] input/hid: Add a new Saitek mouse device ID (RAT 9) |
| |
On Mon, 1 Aug 2016, Benjamin Tissoires wrote:
> > static int hid_uevent(struct device *dev, struct kobj_uevent_env *env) > > { > > - struct hid_device *hdev = to_hid_device(dev); > > + struct hid_device *hdev = to_hid_device(dev); > > Usually, if the change is not related to the patch, it needs to be in > its own patch. The rational being that if we need to revert the patch, > the cleanups won't.
Yeah, let's fix this once someone is actually touching the code in question.
I've removed this hunk, and applied the rest of the patch to for-4.8/upstream-fixes. Thanks,
-- Jiri Kosina SUSE Labs
| |