Messages in this thread | | | Subject | Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property. | From | David Woodhouse <> | Date | Fri, 19 Aug 2016 15:15:19 +0100 |
| |
On Tue, 2016-08-16 at 10:38 +0800, Finlye Xiao wrote: > From: Finley Xiao <finley.xiao@rock-chips.com> > > This patch adds an of_property_read_s32_index() function to allow > reading a single indexed s32 value from a property containing multiple > s32 values. > > Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
NAK.
Nobody should be using the old of_property_* functions any more anyway. You should be using the generic device_propery_* functions which work regardless of where the information comes from (actual DT vs. ACPI _DSD).
So no, don't *add* any more of these functions. Only add the generic version. And if your driver isn't using the generic property functions... fix it.
-- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation[unhandled content-type:application/x-pkcs7-signature] | |