Messages in this thread | | | Date | Thu, 18 Aug 2016 21:07:34 -0700 (PDT) | Subject | Re: [PATCH] smc91c92_cs : add a spinlock to avoid race condition | From | David Miller <> |
| |
From: Pavel Andrianov <andrianov@ispras.ru> Date: Tue, 16 Aug 2016 16:39:06 +0300
> smc_reset may be executed in parallel with timer function media_check. > To avoid data race in smc_set_xcvr a spinlock was added. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Pavel Andrianov <andrianov@ispras.ru>
This is not sufficient.
You have to block basically the entire function, because both smc_reset and media_check program the bank selection so could corrupt eachother's register accesses.
| |