lkml.org 
[lkml]   [2016]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 032/100] arc: unwind: warn only once if DW2_UNWIND is disabled
    Date
    From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 9bd54517ee86cb164c734f72ea95aeba4804f10b upstream.

    If CONFIG_ARC_DW2_UNWIND is disabled every time arc_unwind_core()
    gets called following message gets printed in debug console:
    ----------------->8---------------
    CONFIG_ARC_DW2_UNWIND needs to be enabled
    ----------------->8---------------

    That message makes sense if user indeed wants to see a backtrace or
    get nice function call-graphs in perf but what if user disabled
    unwinder for the purpose? Why pollute his debug console?

    So instead we'll warn user about possibly missing feature once and
    let him decide if that was what he or she really wanted.

    Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
    Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    arch/arc/kernel/stacktrace.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/arc/kernel/stacktrace.c b/arch/arc/kernel/stacktrace.c
    index 9c9e1d3ec5fe..0ebb921e8786 100644
    --- a/arch/arc/kernel/stacktrace.c
    +++ b/arch/arc/kernel/stacktrace.c
    @@ -131,7 +131,7 @@ arc_unwind_core(struct task_struct *tsk, struct pt_regs *regs,
    * prelogue is setup (callee regs saved and then fp set and not other
    * way around
    */
    - pr_warn("CONFIG_ARC_DW2_UNWIND needs to be enabled\n");
    + pr_warn_once("CONFIG_ARC_DW2_UNWIND needs to be enabled\n");
    return 0;

    #endif
    --
    2.9.3
    \
     
     \ /
      Last update: 2016-09-17 09:57    [W:4.402 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site