Messages in this thread | | | Date | Thu, 18 Aug 2016 20:30:28 +0200 | From | "Luis R. Rodriguez" <> | Subject | Re: [RFC PATCH 3/5] Trigger Module.ksymb generation in Makefile |
| |
On Wed, Aug 17, 2016 at 09:27:01PM +0200, Cristina Moraru wrote: > Trigger the generation of file scripts/Module.ksymb in > Makefile by calling updated scripts/streamline_config.pl > with corresponding parameter (--genmodulesymb). The file > is generated at each compilation considering that > associations may change after tree updates.
I really like this approach as you make the resolver configurable, this lets others experiment and consider alternatives.
make KSYMB_GENERATOR=/path/research/my-config-generator-is-better
The fact that you can do this should be documented as part of the patch commit log.
You'll want to wrap this generation under a CONFIG option so only kernels that want generate this file.
> This patch is part of a research project within > Google Summer of Code of porting 'make localmodconfig' > for backported drivers. The goal is to enable each > module to expose in /sys its corresponding CONFIG_* option. > The value of this attribute will be dynamically pegged by > modpost without requiring extra work from the driver developers. > Further, this information will be used by a hardware interogation > tool to extract build information about the existing devices.
You can leave this out.
> > Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com> > --- > Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Makefile b/Makefile > index 393b615..286b949 100644 > --- a/Makefile > +++ b/Makefile > @@ -219,6 +219,10 @@ VPATH := $(srctree)$(if $(KBUILD_EXTMOD),:$(KBUILD_EXTMOD)) > > export srctree objtree VPATH > > +KSYMB_GENERATOR := $(objtree)/scripts/kconfig/streamline_config.pl > +ksymb_gen_command = perl $(KSYMB_GENERATOR) --genmoduleksymb $(objtree) $(Kconfig)
$(PERL)
> +ksymb_update := $(shell objtree=$(objtree) srctree=$(srctree) $(ksymb_gen_command)) > + > # SUBARCH tells the usermode build what the underlying arch is. That is set > # first, and if a usermode build is happening, the "ARCH=um" on the command > # line overrides the setting of ARCH below. If a native build is happening, > -- > 2.7.4
Luis
| |