Messages in this thread Patch in this message | | | Date | Thu, 18 Aug 2016 03:56:31 -0700 | From | tip-bot for Morten Rasmussen <> | Subject | [tip:sched/core] sched/core: Remove unnecessary NULL-pointer check |
| |
Commit-ID: 0e6d2a67a41321b3ef650b780a279a37855de08e Gitweb: http://git.kernel.org/tip/0e6d2a67a41321b3ef650b780a279a37855de08e Author: Morten Rasmussen <morten.rasmussen@arm.com> AuthorDate: Mon, 25 Jul 2016 14:34:21 +0100 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Thu, 18 Aug 2016 11:26:53 +0200
sched/core: Remove unnecessary NULL-pointer check
Checking if the sched_domain pointer returned by sd_init() is NULL seems pointless as sd_init() neither checks if it is valid to begin with nor set it to NULL.
Signed-off-by: Morten Rasmussen <morten.rasmussen@arm.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: dietmar.eggemann@arm.com Cc: freedom.tan@mediatek.com Cc: keita.kobayashi.ym@renesas.com Cc: mgalbraith@suse.de Cc: sgurrappadi@nvidia.com Cc: vincent.guittot@linaro.org Cc: yuyang.du@intel.com Link: http://lkml.kernel.org/r/1469453670-2660-5-git-send-email-morten.rasmussen@arm.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- kernel/sched/core.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 54fff81..1b2dd52 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6854,8 +6854,6 @@ struct sched_domain *build_sched_domain(struct sched_domain_topology_level *tl, struct sched_domain *child, int cpu) { struct sched_domain *sd = sd_init(tl, cpu); - if (!sd) - return child; cpumask_and(sched_domain_span(sd), cpu_map, tl->mask(cpu)); if (child) {
| |