lkml.org 
[lkml]   [2016]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property
Hi Guenter,

How about changing the property name for SuperSpeed as following?
It is more simple and reduce the length of property name.
- EXTCON_PROP_USB_SUPERSPEED -> EXTCON_PROP_USB_SS

Regards,
Chanwoo Choi

On 2016년 08월 16일 10:41, Guenter Roeck wrote:
> On Mon, Aug 15, 2016 at 5:55 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> Hi Guenter,
>>
>> Looks good to me.
>> I'll add the reference[1] information on patch description and applied it.
>> [1] https://en.wikipedia.org/wiki/USB#Overview
>>
>
> Thanks!
>
> Guenter
>
>> Thanks,
>> Chanwoo Choi
>>
>> On 2016년 08월 15일 22:15, Guenter Roeck wrote:
>>> From: Guenter Roeck <groeck@chromium.org>
>>>
>>> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2
>>> and USB3 connections on USB Type-C cables.
>>>
>>> Cc: Chris Zhong <zyw@rock-chips.com>
>>> Signed-off-by: Guenter Roeck <groeck@chromium.org>
>>> ---
>>> Applies on top of extcon-next.
>>>
>>> include/linux/extcon.h | 8 +++++++-
>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
>>> index ad7a1606a7f3..38d2c0dec2c1 100644
>>> --- a/include/linux/extcon.h
>>> +++ b/include/linux/extcon.h
>>> @@ -107,12 +107,18 @@
>>> * @type: integer (intval)
>>> * @value: 0 (normal) or 1 (flip)
>>> * @default: 0 (normal)
>>> + * - EXTCON_PROP_USB_SUPERSPEED
>>> + * @type: integer (intval)
>>> + * @value: 0 (USB/USB2) or 1 (USB3)
>>> + * @default: 0 (USB/USB2)
>>> + *
>>> */
>>> #define EXTCON_PROP_USB_VBUS 0
>>> #define EXTCON_PROP_USB_TYPEC_POLARITY 1
>>> +#define EXTCON_PROP_USB_SUPERSPEED 2
>>>
>>> #define EXTCON_PROP_USB_MIN 0
>>> -#define EXTCON_PROP_USB_MAX 1
>>> +#define EXTCON_PROP_USB_MAX 2
>>> #define EXTCON_PROP_USB_CNT (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1)
>>>
>>> /* Properties of EXTCON_TYPE_CHG. */
>>>
>>
>
>
>

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.172 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site