lkml.org 
[lkml]   [2016]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/2] usb: USB Type-C connector class
Hi,

On Wed, Aug 17, 2016 at 03:14:03PM +0200, Frans Klaver wrote:
> On Wed, Aug 17, 2016 at 12:34 PM, Heikki Krogerus
> > +static const char * const typec_partner_types[] = {
> > + [TYPEC_PARTNER_USB] = "USB",
> > + [TYPEC_PARTNER_CHARGER] = "Charger",
> > + [TYPEC_PARTNER_ALTMODE] = "Alternate Mode",
> > + [TYPEC_PARTNER_ACCESSORY] = "Accessory",
> > +};
> > +
> > +static ssize_t partner_type_show(struct device *dev,
> > + struct device_attribute *attr, char *buf)
> > +{
> > + struct typec_partner *partner = container_of(dev, struct typec_partner,
> > + dev);
> > +
> > + return sprintf(buf, "%s\n", typec_partner_types[partner->type]);
> > +}
> > +
> > +static struct device_attribute dev_attr_partner_type = {
> > + .attr = {
> > + .name = "type",
> > + .mode = S_IRUGO,
> > + },
> > + .show = partner_type_show,
> > +};
>
> Why not use DEVICE_ATTR_RO() for this?

Because I don't want to tie the attribute names to the function names
in this case. There are other *type* attributes being created in the
driver, so type_show() is not good, and we can't name the attribute
"partner_type". The attribute will be placed in group named "partner".

> > +
> > +static ssize_t
> > +partner_accessory_mode_show(struct device *dev, struct device_attribute *attr,
> > + char *buf)
> > +{
> > + struct typec_partner *partner = container_of(dev, struct typec_partner,
> > + dev);
> > +
> > + return sprintf(buf, "%s\n", typec_accessory_modes[partner->accessory]);
> > +}
> > +
> > +static struct device_attribute dev_attr_partner_accessory = {
> > + .attr = {
> > + .name = "accessory",
> > + .mode = S_IRUGO,
> > + },
> > + .show = partner_accessory_mode_show,
> > +};
>
> And this

Ditto.


Thanks,

--
heikki

\
 
 \ /
  Last update: 2016-09-17 09:57    [W:0.693 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site