Messages in this thread | | | Subject | Re: [PATCH v3 2/5] net: ethernet: ti: davinci_cpdma: fix locking while ctrl_stop | From | Mugunthan V N <> | Date | Wed, 17 Aug 2016 11:12:25 +0530 |
| |
On Tuesday 16 August 2016 04:55 AM, Ivan Khoronzhuk wrote: > The interrupts shouldn't be disabled while receiving skb, but while > ctrl_stop, the channels are stopped and all remaining packets are > handled with netif_receive_skb(): > > lock_irq_save > cpdma_ctlr_stop > cpdma_chan_top > __cpdma_chan_free > cpsw_rx_handler > netif_receive_skb > > So, split locking while ctrl stop thus interrupts are still > enabled while skbs handling. It can cause WARN_ONCE in rare > cases when ctrl is stopping while not all packets were handled > with NAPIs. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards Mugunthan V N
| |