lkml.org 
[lkml]   [2016]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags
    On 8 July 2016 at 01:08, Jon Mason <jon.mason@broadcom.com> wrote:
    > mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >>
    > BGMAC_DS_MM_SHIFT;
    > - if (ci->id != BCMA_CHIP_ID_BCM47162 || mode != 0)
    > + if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST || mode != 0)
    > bgmac_set(bgmac, BCMA_CLKCTLST, BCMA_CLKCTLST_FORCEHT);
    > - if (ci->id == BCMA_CHIP_ID_BCM47162 && mode == 2)
    > + if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST && mode == 2)
    > bcma_chipco_chipctl_maskset(&bgmac->core->bus->drv_cc, 1, ~0,
    > BGMAC_CHIPCTL_1_RXC_DLL_BYPASS);

    Jon, it looks to me you translated two following conditions:
    ci->id != BCMA_CHIP_ID_BCM47162
    and
    ci->id == BCMA_CHIP_ID_BCM47162
    into the same flag check:
    bgmac->feature_flags & BGMAC_FEAT_CLKCTLST

    I don't think it's intentional, is it? Do you have a moment to fix this?

    \
     
     \ /
      Last update: 2016-09-17 09:57    [W:4.222 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site